go.mod: require Go 1.25 #5515
Merged
go.mod: require Go 1.25 #5515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require Go 1.25, mirroring Cockroach's master branch, and allowing us to make use of new 1.24 and 1.25 features such as the synctest package.
Member
|
This change is |
Member
|
I think we should wait until there's high confidence we'll stay with 1.25 (last time we had to walk back). CC @rickystewart |
xinhaoz
approved these changes
Oct 31, 2025
Contributor
|
We're going to have lots of problems if this Go upgrade is walked back, having to revert this PR being the least of them. I wouldn't be concerned about this. |
RaduBerinde
approved these changes
Nov 2, 2025
Collaborator
Author
|
TFTRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require Go 1.25, mirroring Cockroach's master branch, and allowing us to make use of new 1.24 and 1.25 features such as the synctest package.